Add ACM Submariner pre-pair validation - #4
Open
TimothyAsirJeyasing wants to merge 2 commits into
Open
Conversation
Introduce the four-step PatternFly wizard (Clusters, Configure, Policy, Review) without Submariner or Globalnet pre-pair validation yet.
TimothyAsirJeyasing
force-pushed
the
rh-8574-mirrorpeer-pre-pair-validation-redesign
branch
from
July 22, 2026 13:10
10ee53c to
12e8396
Compare
Watch ManagedClusterAddOn health for the selected cluster pair, gate the Configure step on canProceed, and keep evaluation in mco utils/hooks. How Submariner is checked (ACM path): - Hub watch only: ManagedClusterAddOn named "submariner" per managed cluster namespace (RHACM Networking docs). No ManagedClusterView in this PR; spoke Broker/Cluster CRs are for upstream/Globalnet later. - NotInstalled: addon object missing (usual) or watch 404 (absent API resource) — not a condition on the MCA spec. Both missing => skip validation and allow Next (UX: Cluster network - Skipped). - Per cluster after addon exists: Available first (SubmarinerAgentAvailable=True); then connected (SubmarinerConnectionDegraded=False) => Healthy. ConnectionDegraded, AgentDegraded, RouteAgentConnectionDegraded, or unlabeled gateway => Degraded. Available not ready / connection unset => Progressing. - Pair gate: both NotInstalled or both Healthy => canProceed; one-sided install => Inconsistent (block); otherwise Degraded/Progressing block. Why this combination (vs connectivity-only): - Available then ConnectionDegraded matches ACM's documented MCA conditions for deploy + established connections. Extra degraded signals (agent/route/gateway) fail closed so we do not treat a half-ready addon as connected. Can narrow the gate later if product wants ConnectionDegraded alone. Out of scope here: Globalnet/CIDR overlap warnings, MCV lifecycle.
TimothyAsirJeyasing
force-pushed
the
rh-8574-pr2-acm-submariner-validation
branch
from
July 22, 2026 13:30
794f95c to
2bcfe01
Compare
TimothyAsirJeyasing
force-pushed
the
rh-8574-mirrorpeer-pre-pair-validation-redesign
branch
5 times, most recently
from
July 28, 2026 09:28
bcfbbc9 to
c892b60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds ACM-managed Submariner pre-pair validation to the Create DRPolicy wizard.
During the Configure step, the selected cluster pair is validated using the ACM
ManagedClusterAddOnresource. Users can continue only when the selected pair is ready for pairing.The validation logic is kept separate from the UI:
Out of scope
This PR covers ACM-managed Submariner validation only.
Validation for upstream Submariner deployments (using ManagedClusterView and Submariner Broker/Cluster resources) will be added in a follow-up PR.